Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

Updates to the script #4

Merged
merged 5 commits into from
Mar 30, 2015
Merged

Updates to the script #4

merged 5 commits into from
Mar 30, 2015

Conversation

MBtech
Copy link
Contributor

@MBtech MBtech commented Mar 29, 2015

Added features

  1. Removed the need to for sudo. The tool are downloaded into the script directory.
  2. User now has the option to specify the output directory for the decomipled output.

changes to avoid sudo access and debian python interpreter policy used
Added option for used to specify output directory
@TheZ3ro
Copy link
Owner

TheZ3ro commented Mar 29, 2015

Great!

Just a little thing, what's the purpose of replacing #!/usr/bin/env python3 with #!/usr/bin/python3?

I think using env is much portable (It's a POSIX component thus found in pretty much every system),
hard coding the python interpreter path is good on Debian systems (see debian python policy) but I think that the key point is don't get Error on users' system.
(maybe users use virtualenv or python is installed in /usr/local/bin/.)

What do you think about? 😄

@MBtech
Copy link
Contributor Author

MBtech commented Mar 30, 2015

You are right, I guess.
Though using #!/user/bin/env python3 was giving me weird problems on my ubuntu system.
Apparently there is a problem in the env file that I had. It's messed up because of some other android stuff. Need to look into it.

@TheZ3ro
Copy link
Owner

TheZ3ro commented Mar 30, 2015

It's ok, so you can make a new commit to fix that?

When it's ready I will merge the pull request 👍

Generic python policy
@MBtech
Copy link
Contributor Author

MBtech commented Mar 30, 2015

Done :)

TheZ3ro pushed a commit that referenced this pull request Mar 30, 2015
Added features
1. Removed the need to for sudo. The tool are downloaded into the script directory.
2. User now has the option to specify the output directory for the decomipled output.
@TheZ3ro TheZ3ro merged commit 2c22142 into TheZ3ro:master Mar 30, 2015
@TheZ3ro
Copy link
Owner

TheZ3ro commented Mar 30, 2015

Thanks, merge done :)

@MBtech
Copy link
Contributor Author

MBtech commented Mar 30, 2015

Perfect :D

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants